Implement Pointer Events Context for Enhanced Interaction Handling #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new `PointerEventsContext` to manage pointer event registrations across components. - Updated `Application.tsx` to provide the `PointerEventsContext` to child components. - Modified `Entity.tsx` to utilize the context for adding and removing pointer event listeners dynamically. - Enhanced `usePicker` utility to check for registered pointer events before processing interactions. These changes improve the handling of pointer events, allowing for more flexible and efficient interaction management within the application.
- Added `PointerEventsProvider` to manage registered pointer events and provide context to child components. - Updated `picker.tsx` to include the new provider, improving interaction handling by enabling dynamic event registration. - Refactored existing logic to utilize the `PointerEventsContext`, enhancing the flexibility of pointer event management. These changes improve the overall interaction capabilities within the application.
…ent handling - Updated the `usePicker` utility to accept a `pointerEvents` parameter, allowing for more dynamic interaction management. - Modified the `Application` component to correctly utilize the updated `usePicker` function, ensuring pointer events are registered and processed efficiently. - Reorganized the context providers in `Application` for better clarity and structure.
- Updated the Entity component to accept pointer event handlers as props instead of defaulting to no-ops. - Added conditional checks to register and unregister pointer event listeners only if the corresponding handlers are provided. - This change enhances flexibility and allows for more dynamic interaction management within the Entity component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes the Picker to only run when a
onPointer*prop is passed to a child entity. This should improve performance for non interactive appsPointerEventsContextto manage pointer event registrations across components.Application.tsxto provide thePointerEventsContextto child components.Entity.tsxto utilize the context for adding and removing pointer event listeners dynamically.usePickerutility to check for registered pointer events before processing interactions.These changes improve the handling of pointer events, allowing for more flexible and efficient interaction management within the application.