New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update viewer app #388

Merged

slimbuck merged 2 commits into playcanvas:main from slimbuck:viewer-dev

Jan 27, 2025

Member

slimbuck commented Jan 27, 2025

This PR:

store the viewer templates as text (instead of ts) and add a rollup plugin to load it at build time
- this is simpler to develop (for now)
- unfortunately we must rename the files with .template extension so they aren't picked up by postcss
viewer renders on demand (only when camera moves)
viewer has more accurate FOV handling compared to SuperSplat

Notes

It would be awesome if the template files could retain their extensions. If anyone knows how to accomplish this with rollup please submit a PR!
It will probably make sense to extract the viewer into a separate repo/package in future


          latest

5d09303

slimbuck added the enhancement label

slimbuck requested a review from a team

January 27, 2025 11:24

slimbuck self-assigned this

willeastcott approved these changes

View reviewed changes


          lint

9ddd0cc

slimbuck merged commit 8d76535 into playcanvas:main

2 checks passed

slimbuck deleted the viewer-dev branch

January 27, 2025 11:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels