Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: expose onstart and beforetransition hook, create syncwaterfall js backed hook #582

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nancywu1
Copy link
Contributor

@nancywu1 nancywu1 commented Jan 30, 2025

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs
📦 Published PR as canary version: 0.10.3--canary.582.19520

Try this version out locally by upgrading relevant packages to 0.10.3--canary.582.19520

@nancywu1 nancywu1 changed the title expose onstart and beforetransition plugin expose onstart and beforetransition hook Jan 30, 2025
@nancywu1 nancywu1 changed the title expose onstart and beforetransition hook iOS: expose onstart and beforetransition hook, create syncwaterfall js backed hook Jan 30, 2025
@nancywu1
Copy link
Contributor Author

/canary

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 80.35714% with 22 lines in your changes missing coverage. Please review.

Project coverage is 89.71%. Comparing base (cfdf872) to head (7110539).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
ios/core/Sources/Types/Hooks/Hook.swift 45.94% 20 Missing ⚠️
ios/core/Sources/Types/Core/FlowType.swift 83.33% 1 Missing ⚠️
ios/core/Tests/FlowStateTests.swift 98.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
- Coverage   89.75%   89.71%   -0.05%     
==========================================
  Files         331      332       +1     
  Lines       19836    19947     +111     
  Branches     1949     1949              
==========================================
+ Hits        17804    17895      +91     
- Misses       2018     2038      +20     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant