Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore streaming in StandaloneWSRequest.stream() #803

Merged
merged 1 commit into from
Oct 4, 2023
Merged

restore streaming in StandaloneWSRequest.stream() #803

merged 1 commit into from
Oct 4, 2023

Conversation

maxcom
Copy link
Contributor

@maxcom maxcom commented Oct 2, 2023 •
edited
Loading

Pull Request Checklist

  • Have you read through the contributor guidelines?
  • Have you squashed your commits?
  • Have you added copyright headers to new files?
  • Have you checked that both Scala and Java APIs are updated?
  • Have you updated the documentation for both Scala and Java sections?
  • Have you added tests for any changed functionality?

Fixes

Fixes #802. Please also port this fix to 2.2.x branch.

Also this fix removed usage of scala.concurrent.ExecutionContext.Implicits.global.

@mkurz mkurz merged commit 0e65ae9 into playframework:main Oct 4, 2023
12 checks passed
@mkurz
Copy link
Member

mkurz commented Oct 4, 2023

@Mergifyio backport 2.2.x

@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2023 •
edited
Loading

backport 2.2.x

✅ Backports have been created

@mergify mergify bot mentioned this pull request Oct 4, 2023
Merged
mergify bot added a commit that referenced this pull request Oct 4, 2023
@mergify
Merge pull request #805 from playframework/mergify/bp/2.2.x/pr-803
7544694 
[2.2.x] restore streaming in StandaloneWSRequest.stream() (backport #803) by @maxcom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scala StandaloneWSRequest.stream() buffers entire response in memory
2 participants
@maxcom @mkurz