fix(tests): adding tests (#16)

improving internal testing of module to comply with new standards

.commitlintrc.yml

@@ -0,0 +1,8 @@
+# See rules: https://github.com/conventional-changelog/commitlint/blob/master/docs/reference-rules.md
+extends:
+  - '@commitlint/config-conventional'
+rules:
+  subject-case: [ 1, 'always', 'lower-case' ] # Warn but don't error on subject-case
+  subject-full-stop: [ 0, 'never', '.' ] # Disable error on subject-full-stop
+  body-max-line-length: [ 2, 'always', 'Infinity' ]
+  footer-max-line-length: [ 1, 'always', 100 ] # Warn but don't error on footer length because it's silly

.github/CODEOWNERS

@@ -1 +1 @@
-*  @isasand @twiden @SebRosander @marcmodin
+*  @playgroundtech/owners

.github/workflows/pr.yaml

@@ -0,0 +1,27 @@
+jobs:
+  commitlint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
+      - uses: wagoid/commitlint-github-action@v5
+  pre-commit:
+    name: Pre-Commit
+    runs-on: macos-latest
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
+      - name: Update Repo
+        run: brew update
+      - name: Install Deps
+        run: brew install pre-commit gitleaks tflint tfsec terraform-docs terraform || true
+      - name: Terraform init
+        run: terraform init
+      - name: Check Pre Commit
+        run: pre-commit run --show-diff-on-failure -a
+
+name: PR checks
+on:
+  - pull_request

.github/workflows/semantic-release.yaml

@@ -0,0 +1,21 @@
+jobs:
+  semver-release:
+    name: Semantic Release
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+      - env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        name: Semantic Release
+        uses: cycjimmy/semantic-release-action@v3
+        with:
+          extra_plugins: |
+            @semantic-release/[email protected]
+            @semantic-release/[email protected]
+          semantic_version: 17
+name: Release
+on:
+  push:
+    branches:
+      - master

.github/workflows/terratest.yml

@@ -20,7 +20,7 @@ jobs:
     defaults:
       run:
         shell: bash
-        working-directory: test
+        working-directory: tests
 
     steps:
       # Checkout the repository to the GitHub Actions runner
@@ -36,11 +36,13 @@ jobs:
       # Install and set up Golang
       - name: Set Up Go
         uses: actions/setup-go@v2
+        with:
+          go-version: 1.19.x
 
       # Get all golang dependencies
       - name: Get dependencies
         run: go mod tidy
 
       # Run terratest
       - name: Run Terratest
-        run: go test -timeout 90m
+        run: go test -timeout 90m

.gitignore

@@ -33,4 +33,4 @@ override.tf.json
 *tfplan*
 
 # IntelliJ IDEA
-*.idea
+*.idea

.pre-commit-config.yaml

@@ -0,0 +1,28 @@
+repos:
+  - repo: https://github.com/antonbabenko/pre-commit-terraform
+    rev: v1.77.1
+    hooks:
+      - id: terraform_fmt
+      - id: terraform_validate
+      - id: terraform_docs
+      - id: terraform_tfsec
+      - id: terraform_tflint
+        args:
+          - '--args=--only=terraform_deprecated_interpolation'
+          - '--args=--only=terraform_deprecated_index'
+          - '--args=--only=terraform_unused_declarations'
+          - '--args=--only=terraform_comment_syntax'
+          - '--args=--only=terraform_module_pinned_source'
+          - '--args=--only=terraform_naming_convention'
+          - '--args=--only=terraform_workspace_remote'
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v4.3.0
+    hooks:
+      - id: check-yaml
+      - id: check-json
+      - id: check-merge-conflict
+      - id: end-of-file-fixer
+  - repo: https://github.com/zricethezav/gitleaks
+    rev: v8.16.0
+    hooks:
+      - id: gitleaks

.releaserc.yml

@@ -0,0 +1,19 @@
+ci: true
+debug: false
+plugins:
+  - - '@semantic-release/commit-analyzer'
+    - preset: angular
+  - - '@semantic-release/release-notes-generator'
+    - preset: angular
+      writerOpts:
+        commitsSort:
+          - subject
+          - scope
+  - '@semantic-release/github'
+publish:
+  - '@semantic-release/github'
+repositoryUrl: https://github.com/playgroundtech/terraform-aws-github-actions-oidc
+verifyConditions:
+  - '@semantic-release/github'
+branches:
+  - master

CHANGELOG.md

@@ -1,21 +1,36 @@
+# v2.0.1
+
+Internal refactoring of the module to comply with new standards.
+
+FEATURES
+
+ENHANCEMENTS
+
+* Several tests added to the module.
+
+BUG FIXES
+
 # v2.0.0
+
 The release contains breaking changes, be careful when you update your module
-since it may involve downtime with a changed behavior of network traffic.  
+since it may involve downtime with a changed behavior of network traffic.
 
 FEATURES
 
 ENHANCEMENTS
-* Complete rework of how we handle NAT Gateways. 
+
+* Complete rework of how we handle NAT Gateways.
   Now supports HA solutions and are deployed over all given availability zones.
-    
+
 * Added variable `nat_route_table` to make it possible to choose wether to
   create own route tables or let the module create them for you.
 
 BUG FIXES
 
-
 # v1.0.0
+
 FEATURES
+
 * Release of v1.0.0
 
 ENHANCEMENTS

LICENSE

@@ -370,4 +370,4 @@ Exhibit B - "Incompatible With Secondary Licenses" Notice
 ---------------------------------------------------------
 
   This Source Code Form is "Incompatible With Secondary Licenses", as
-  defined by the Mozilla Public License, v. 2.0.
+  defined by the Mozilla Public License, v. 2.0.

internet_gateway.tf

@@ -33,4 +33,4 @@ resource "aws_route_table_association" "igw" {
   for_each       = local.public_subnets
   route_table_id = aws_route_table.igw[0].id
   subnet_id      = aws_subnet.subnets[each.key].id
-}
+}

main.tf

@@ -1,3 +1,3 @@
 terraform {
   required_version = "~> 1.0"
-}
+}

subnets.tf

@@ -10,4 +10,4 @@ resource "aws_subnet" "subnets" {
     },
     var.vpc_tags
   )
-}
+}