Fix serializeValue to properly handle slices #411
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes serialization of slices when passed as argument to Evaluate().
I found two issues with how slices are serialized:
I also added a few tests.
I discovered that passing floats and time will not work.
We do not correctly serialize valid floats but when I tried fixing it I got the following error:
playwright: arg.value.v: expected one of (null|undefined|NaN|Infinity|-Infinity|-0)
Unfortunately, I wasn't able to fix this.