Skip to content

feat: Add no-shell option to run.go #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add no-shell option to run.go #571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,10 @@
additionalArgs = append(additionalArgs, "--only-shell")
}

if d.options.NoInstallShell {
additionalArgs = append(additionalArgs, "--no-shell")
}

if d.options.DryRun {
additionalArgs = append(additionalArgs, "--dry-run")
}
Expand Down Expand Up @@ -239,7 +243,9 @@
// - Linux: ~/.cache
DriverDirectory string
// OnlyInstallShell only downloads the headless shell. (For chromium browsers only)
OnlyInstallShell bool

Check failure on line 246 in run.go

View workflow job for this annotation

GitHub Actions / Lint 

File is not properly formatted (gofumpt)
// NoInstallShell does not install chromium headless shell. (For chromium browsers only)
NoInstallShell bool
SkipInstallBrowsers bool
// if not set and SkipInstallBrowsers is false, will download all browsers (chromium, firefox, webkit)
Browsers []string
Expand Down Expand Up @@ -297,6 +303,9 @@
if len(options) == 1 {
option = options[0]
}
if option.OnlyInstallShell && option.NoInstallShell {
return nil, fmt.Errorf("OnlyInstallShell and NoInstallShell cannot be set at the same time")
}
if option.DriverDirectory == "" { // if user did not set it, try to get it from env
option.DriverDirectory = os.Getenv("PLAYWRIGHT_DRIVER_PATH")
}
Expand Down
Loading