Abi hdrs from deps #166
Merged
Abi hdrs from deps #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tatskaari
force-pushed
the
abi-hdrs-from-deps
branch
from
aaa9998 to
427fe3d
Compare
samwestmoreland
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to get the .h files of go_libraries we depend on. This is useful for cases such as this:
https://github.com/cloudflare/circl/blob/main/dh/x448/curve_amd64.s
Where we want to include a header from a dep using
../../math/fp448/fp_amd64.hWe should do this through the normal require/provide setup once we figure out thought-machine/please#2931 (review)