Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide pkginfo on go_library #209

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Provide pkginfo on go_library #209

merged 1 commit into from
Jan 18, 2024

Conversation

Tatskaari
Copy link
Contributor

No description provided.

@Tatskaari Tatskaari changed the title Provide pkginfo on go_libarary Provide pkginfo on go_library Jan 18, 2024
@Tatskaari Tatskaari force-pushed the provide-pkg-info-go-lib branch from 126026a to c43d802 Compare January 18, 2024 10:33
peterebden
peterebden approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@peterebden peterebden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh I'm surprised we missed this all this time

build_defs/go.build_defs Outdated
)]
visibility = visibility,
)
deps += []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary

@Tatskaari Tatskaari force-pushed the provide-pkg-info-go-lib branch from c43d802 to 97f223a Compare January 18, 2024 10:40
@Tatskaari Tatskaari merged commit 17e16e8 into please-build:master Jan 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterebden peterebden peterebden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tatskaari @peterebden