Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove options struct for the deleted "get" subcommand. #309

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Remove options struct for the deleted "get" subcommand. #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db1de81
Remove options struct for the deleted "get" subcommand.
timburks Nov 26, 2024
5cf481b
Update VERSION and Changelog for please_go.
timburks Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tools/please_go/ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
Version 1.15.2
--------------
* Fully remove `get` subcommand (#309)

Version 1.15.1
--------------
* Use more specific names for coverage variables to avoid clashes
Expand Down
2 changes: 1 addition & 1 deletion tools/please_go/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.15.1
1.15.2
6 changes: 0 additions & 6 deletions tools/please_go/please_go.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,6 @@ var opts = struct {
Requirements []string `positional-arg-name:"requirements" description:"Any module requirements not included in the go.mod"`
} `positional-args:"true"`
} `command:"generate" alias:"g" description:"Generate build targets for a Go module"`
GoGet struct {
ModFile string `short:"m" long:"mod_file" description:"A go.mod file to use as a set of reuirementzs"`
Args struct {
Requirements []string `positional-arg-name:"requirements" description:"a set of module@version pairs"`
} `positional-args:"true"`
} `command:"get" description:"Generate go_get rules"`
ModInfo struct {
GoTool string `short:"g" long:"go" env:"TOOLS_GO" required:"true" description:"The Go tool we'll use"`
ModulePath string `short:"m" long:"module_path" description:"The path for the module being built"`
Expand Down