Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg_config arguments now come before ldflags when acquired from cgo_library #310

Closed
wants to merge 1 commit into from

Conversation

peterebden
Copy link
Contributor

I have a case where I need to add an extra flag for the output of pkg-config to work (I don't know why it comes off the system this way...). I should be able to do this via ldflags, however in the current setup those are added to the command line before the pkg-config invocation which is too early.

I think this seems more useful - I think it's not hyper-optimising just for this use case although it does feel quite specific.

@peterebden
Copy link
Contributor Author

Okay I think a better way to solve my specific problem happens to be to invoke the compiler as clang++ instead of clang. I don't think this change is all bad but I'd rather not mess with it if I don't have to (I think there is scope for it breaking something else that relied on the current ordering).

@peterebden peterebden closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant