forked from wormhole-foundation/wormhole
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Governor/custom reset release timer delay #1
Draft
pleasew8t
wants to merge
10
commits into
main
Choose a base branch
from
governor/custom-reset-release-timer-delay
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djb15
reviewed
Jun 13, 2024
claudijd
reviewed
Jun 14, 2024
SEJeff
reviewed
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nits, but this looks pretty good from a cursory overview.
SEJeff
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you submit this to the main wormhole repo, I will ✅
pleasew8t
force-pushed
the
governor/custom-reset-release-timer-delay
branch
from
June 19, 2024 05:36
b8d2c6e
to
c55afe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds an additional parameter to the
governor-reset-release-timer
admin command,num_days
.num_days
allows operators to specify the number of days a pending VAA's release needs to be reset to. This allows operators to specify delays larger than the current default (24 hours).The parameter is optional and, if omitted, will default to the current implementation's reset value of 24 hours. If specified, the parameter may not be less than 1 day, or exceed 7 days, otherwise the release time reset will fail.
Use-case
This feature is particularly useful in scenarios where follow-up delays beyond 24 hours are anticipated, but participation by guardians cannot be guaranteed. For example, a VAA gets enqueued by the governor (imposing a delay of 24 hours), but some guardians opt to delay the VAA's release even further.
If one of these guardians recognizes that they will not be available to reset the delay over the course of the following two days, the said guardian could use the
governor-reset-release-timer
command to proactively delay the release to 2, or even 3, days.Summary of code changes
ClientChainGovernorResetReleaseTimerCmd
admin client commandnum_days
field to theChainGovernorResetReleaseTimerRequest
protobuf messageChainGovernorResetReleaseTimer
RPC serviceTestNumDaysForReleaseTimerReset
governor test