Don't skip failed actions on preparation stage #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpushkaryov
suggested changes
Apr 12, 2024
| simple_action._prepare_action.assert_called_once() | ||
| saved_action._prepare_action.assert_called_once() | ||
|
|
||
| def test_skip_failed_saved_state(self): |
There was a problem hiding this comment.
These 3 tests are almost identical. Could they be converted into invocations of a single function with different parameters?
There was a problem hiding this comment.
Not sure it will simplify things, but ok let's do it
kpushkaryov
suggested changes
Apr 12, 2024
| saved_action = SavedAction() | ||
|
|
||
| if phase == "prepare": | ||
| simple_action._prepare_action = mock.Mock(return_value=action.ActionResult()) |
There was a problem hiding this comment.
I suggest to use setattr() and getattr() to avoid duplicating these assignments.
kpushkaryov
approved these changes
Apr 16, 2024
added 2 commits
April 16, 2024 07:34
We need to make all required actions on the preparation stage, so if some action has been failed, we should re-perform it
oved the logic for tests into a separate function since it was nearly identical
SandakovMM
force-pushed
the
no-skip-failed
branch
from
7035418 to
f1ed9cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make all required actions on the preparation stage, so if some action has been failed, we should re-perform it