Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move reboot out of lock #50

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Move reboot out of lock #50

merged 3 commits into from
Jul 12, 2024

Conversation

SandakovMM
Copy link
Contributor

No description provided.

@SandakovMM SandakovMM requested a review from kpushkaryov July 11, 2024 08:05
@SandakovMM SandakovMM self-assigned this Jul 11, 2024
@@ -47,12 +47,15 @@ def start_flow(
# Unfortunately, dataclasses available since Python 3.7 aren't supported
# on Ubuntu 18 (Python 3.6)
class ConvertResult:
successful: bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just success would be enough, I think.

@SandakovMM SandakovMM requested a review from kpushkaryov July 12, 2024 07:51
Copy link
Contributor

@kpushkaryov kpushkaryov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase before merge.

@SandakovMM SandakovMM force-pushed the move-reboot-out-of-lock branch from 760a450 to f149b15 Compare July 12, 2024 09:11
@SandakovMM SandakovMM merged commit 6898408 into main Jul 12, 2024
3 checks passed
@SandakovMM SandakovMM deleted the move-reboot-out-of-lock branch July 12, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants