Don't write motd message on receiving signal on reboot #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukablan-wpc
reviewed
Oct 9, 2024
pleskdistup/main.py
Outdated
| @@ -615,6 +615,12 @@ def main(): | |||
| log.debug(f"Removed the resume file {options.resume_path!r}") | |||
| os.unlink(options.completion_flag_path) | |||
|
|
|||
| # After lock there's no need to manage signals in such a detailed manner | |||
| # Simply log the reason for not rebooting | |||
| exit_signal_handler = create_exit_signal_handler(util_name) | |||
There was a problem hiding this comment.
why do we need exit_signal_handler creation here?
There was a problem hiding this comment.
Damn, we don't need it, you right
ukablan-wpc
reviewed
Oct 9, 2024
pleskdistup/main.py
Outdated
Comment on lines
621
to
622
| for signum in (signal.SIGINT, signal.SIGTERM, signal.SIGHUP, signal.SIGABRT): | ||
| signal.signal(signum, lambda signum, frame: log.info(f"Received signal {signum}, going to exit...")) |
There was a problem hiding this comment.
maybe you can unify both for signum.. constructs under one def assign_killing_signals..(ff: Callable)
ukablan-wpc
approved these changes
Oct 9, 2024
SandakovMM
force-pushed
the
avoid-motd-change-on-reboot
branch
from
3baa2bc to
0180a21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.