Check fstab raid names #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SandakovMM
force-pushed
the
check-fstab-raid-names
branch
from
c35ff6c to
1230830
Compare
ukablan-wpc
reviewed
Dec 9, 2024
pleskdistup/actions/filesystem.py
Outdated
| @@ -0,0 +1,64 @@ | |||
| # Copyright 2023-2024. WebPros International GmbH. All rights reserved. | |||
There was a problem hiding this comment.
Why not define in mounts.py?
There was a problem hiding this comment.
Maybe actions/mounts.py
There was a problem hiding this comment.
And then move get_fstab_configuration_misorderings() inside this source?
There was a problem hiding this comment.
Maybe actions/mounts.py
Let's rename the file, why not.
And then move get_fstab_configuration_misorderings() inside this source?
It might be challenging to import it from actions into the test, so I prefer to keep it in the common directory
ukablan-wpc
reviewed
Dec 9, 2024
ukablan-wpc
approved these changes
Dec 9, 2024
added 2 commits
December 10, 2024 10:06
…he /etc/fstab file RAID devices might get renamed after the conversion, causing issues with mounting and potentially leading to boot problems for a converted host.
SandakovMM
force-pushed
the
check-fstab-raid-names
branch
from
93ab328 to
7153b92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.