Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datepicker popover #61

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Datepicker popover #61

wants to merge 7 commits into from

Conversation

demshy
Copy link
Member

@demshy demshy commented Nov 16, 2024

Changing date picker so it makes use of Headless popover component for positioning according to available space.
Had to move trigger out of the Field element and made the popover stick to the right side of the field, where the trigger is.

@salamca
Copy link
Contributor

salamca commented Nov 17, 2024

  • pressing the calendar button multiple times keeps opening the popover. it should toggle it.

  • popover is a bit to close to the input

image

  • there is a slight gap on the left end of the border below month. probably noone will notice, but if fix minor, could close the gap :)

image

  • doesn't play nice inside log dialog

image

image

@demshy
Copy link
Member Author

demshy commented Nov 19, 2024

should be ok

  • matched gap
  • fixed the button to top instead of bottom and forgot about the label :)
  • reopening fixed by passing {...rest} params in button
  • removed margin that made the gap

@demshy demshy requested a review from salamca November 19, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants