Skip to content

Commit

Permalink
Merge branch 'master' into SMS-6010
Browse files Browse the repository at this point in the history
  • Loading branch information
mohsin-plivo committed Aug 3, 2023
2 parents d508bf4 + 60ab784 commit 0d4b251
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 15 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Change Log

## [4.52.0](https://github.com/plivo/plivo-php/tree/v4.52.0) (2023-07-18)
- Removed object_id and object_type in the parameter as well as response in [list all numbers API]

## [v4.51.0](https://github.com/plivo/plivo-php/tree/v4.51.0) (2023-06-28)
**Audio Streaming**
- API support for starting, deleting, getting streams on a live call
Expand Down
6 changes: 0 additions & 6 deletions src/Plivo/Resources/Number/Number.php
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,6 @@ function __construct(BaseClient $client, array $response, $authId)
'renewalDate' => $response['renewal_date'],
'cnamLookup' => isset($response['cnam_lookup']) ? $response['cnam_lookup'] : null,
];
if (isset($response['object_id'])) {
$this->properties['objectId'] = $response['object_id'];
}
if (isset($response['object_type'])) {
$this->properties['objectType'] = $response['object_type'];
}
$this->pathParams = [
'authId' => $authId,
'number' => $response['number']
Expand Down
2 changes: 1 addition & 1 deletion src/Plivo/Version.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class Version
/**
* @const int PHP helper library minor version number
*/
const MINOR = 51;
const MINOR = 52;

/**
* @const int PHP helper library patch number
Expand Down
2 changes: 0 additions & 2 deletions tests/Mocks/numberGetResponse.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@
"compliance_application_id": "20372631212782797",
"compliance_status": "submitted",
"renewal_date": "2014-03-14",
"object_id": "9565321542215",
"object_type": "trunk",
"tendlc_campaign_id": "CWDPZZX",
"tendlc_registration_status": "UNREGISTERED",
"toll_free_sms_verification": null
Expand Down
6 changes: 0 additions & 6 deletions tests/Mocks/numberListResponse.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@
"compliance_application_id": "20372631212782797",
"compliance_status": "submitted",
"renewal_date": "2014-09-05",
"object_id": "9565321542215",
"object_type": "trunk",
"tendlc_campaign_id": "CWDPZZX",
"tendlc_registration_status": "COMPLETED",
"toll_free_sms_verification": null
Expand Down Expand Up @@ -62,8 +60,6 @@
"compliance_application_id": "20372631212782797",
"compliance_status": "submitted",
"renewal_date": "2013-02-01",
"object_id": "9565321542215",
"object_type": "trunk",
"tendlc_campaign_id": "CWDPZZX",
"tendlc_registration_status": "PROCESSING",
"toll_free_sms_verification": null
Expand Down Expand Up @@ -92,8 +88,6 @@
"compliance_application_id": "20372631212782799",
"compliance_status": "submitted",
"renewal_date": "2013-04-25",
"object_id": "9565321542215",
"object_type": "trunk",
"tendlc_campaign_id": null,
"tendlc_registration_status": null,
"toll_free_sms_verification": "unverified"
Expand Down

0 comments on commit 0d4b251

Please sign in to comment.