proposal for mouseover marker toggle

pllim · Jan 18, 2023 · da4a704 · da4a704
1 parent 6cb7ff2
commit da4a704
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/jdaviz/configs/default/plugins/plot_options/plot_options.vue b/jdaviz/configs/default/plugins/plot_options/plot_options.vue
@@ -23,7 +23,7 @@
               <v-switch v-if="config=='specviz'"
                 v-model="show_mouseover_marker"
                 label="Show mouseover marker"
-                hint="Whether to show a marker at the mouse position"
+                hint="Show a marker at the mouse position"
                 persistent-hint
               ></v-switch>
             </v-row>

diff --git a/jdaviz/configs/specviz/plugins/viewers.py b/jdaviz/configs/specviz/plugins/viewers.py
@@ -65,6 +65,11 @@ def on_mouse_or_key_event(self, data):
             else:  # pragma: no cover
                 return
 
+        # only handle mouseover markers if the setting is selected:
+        plot_options_plugin = self.jdaviz_app.get_tray_item_from_name('g-plot-options')
+        if not plot_options_plugin.show_mouseover_marker:
+            return
+
         if data['event'] == 'mousemove':
             if len(self.jdaviz_app.data_collection) < 1:
                 return