Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused redirectOnResponse on delete action #3198

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove unused redirectOnResponse on delete action #3198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f4cbb6
Remove unused redirectOnResponse on delete action
fulv Oct 14, 2020
c7b97ed
Create 3197.bugfix
fulv Oct 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Products/CMFPlone/profiles/default/actions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@
<element value="Delete objects"/>
</property>
<property name="visible">True</property>
<property name="modal" type="text">{"actionOptions": {"disableAjaxFormSubmit":true, "redirectOnResponse":true}}</property>
<property name="modal" type="text">{"actionOptions": {"disableAjaxFormSubmit":true}}</property>
</object>
<object name="rename" meta_type="CMF Action" i18n:domain="plone">
<property name="title" i18n:translate="">Rename</property>
Expand Down Expand Up @@ -269,7 +269,7 @@
<element value="View"/>
</property>
<property name="visible">True</property>
<property name="modal" type="text">{"prependContent": ".portalMessage", "title": "Log in", "width": "26em", "actionOptions": {"redirectOnResponse": true}}</property>
<property name="modal" type="text">{"prependContent": ".portalMessage", "title": "Log in", "width": "26em", "actionOptions": {"ReResponse": true}}</property>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo / bad remove here 😉

</object>
<object name="join" meta_type="CMF Action" i18n:domain="plone">
<property name="title" i18n:translate="">Register</property>
Expand Down
2 changes: 2 additions & 0 deletions news/3197.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Toolbar <delete> action: Remove unused redirectOnResponse from modal actionOptions. (#3197)
[fulv]