Changed twitter link to x

[SarthakPaandey]

As part of the recent rebranding of Twitter to X, we propose updating all references to Twitter links (twitter.com) in the codebase and documentation to x.com. This change aligns with the platform's new branding and ensures consistency in all related references.
This update is necessary to maintain brand consistency within the project and provide an accurate reflection of the external service's current branding. By updating the links to x.com, we ensure that users and developers are not confused by outdated references to Twitter.
Fix #3994

[mister-roboto]

@SarthakPaandey you need to sign the Plone Contributor Agreement to merge this pull request.

Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement

[mister-roboto]

@SarthakPaandey thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

[SarthakPaandey]

@jenkins-plone-org please run jobs

[SarthakPaandey]

Kindly look into this pull request.

[rohnsha0]

I'm not sure we need this PR. As far as I know, any attempt to access twitter.com gets redirected to x.com. That means all the links that are currently pointing to twitter.com aren't broken.

Am I missing something? @SarthakPaandey
Infact, changing the user-side mentions of Twitter to X makes more sense
 

@gforcada kindly look into this pull request.

please dont tag like this. request a review instead

[SarthakPaandey]

Yes @rohnsha0 but in future we still need to change it and why go redirect when you can easily go to the x.com links. Is there any problem in it? I am also trying to change the user side mentions of twitter if you can point out that which specific twitter mentions we need to change then it will be great! Looking forwards towards your help.

[rohnsha0]

Okay, but please change the references (#3994 (comment)) in https://github.com/plone/plone.base/blob/3a5aef0e158da872d2280cb0150d94c65417120f/src/plone/base/interfaces/controlpanel.py#L1593-L1602 as well. Submit a separate PR for those changes, and include a reference to this PR.

[rohnsha0]

Ill suggest changing to

project_urls={
        # other entries...
        "X (formerly Twitter)": "https://x.com/plone",
        # other entries...
    },

[SarthakPaandey]

Ill suggest changing to

project_urls={
        # other entries...
        "X (formerly Twitter)": "https://twitter.com/plone",
        # other entries...
    },

should i add x.com or not?

[rohnsha0]

Ill suggest changing to

project_urls={
        # other entries...
        "X (formerly Twitter)": "https://twitter.com/plone",
        # other entries...
    },

should i add x.com or not?

Ofc

[stevepiercy]

@SarthakPaandey you should first satisfy contributing requirements, as I mentioned in the original issue. We cannot accept a PR until you do so. Thank you!

[SarthakPaandey]

I have already signed the agreement. Do i need to submit it anywhere?

[stevepiercy]

I have already signed the agreement. Do i need to submit it anywhere?

Yes. Again, please read my original comment about contributing. Thank you!

[mauritsvanrees]

I as Plone Release Manager am happy to accept this small change, even if the contributor agreement has not been handled yet. I can make such exceptions.
First changing the title to "X (formerly Twitter)" as suggested may be good.