Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix robot test Scenario After you fix linked page no longer show warning #4025

Closed
wants to merge 2 commits into from

Conversation

wesleybl
Copy link
Member

@wesleybl wesleybl commented Oct 9, 2024

Wait for page Foo to load before clicking delete.

Fixes:

Element 'css=.breach-container .breach-item' did not appear in 7 seconds.

See: https://jenkins.plone.org/job/pull-request-6.1-3.12/707/robot/report/robot_log.html#s1-s25

@mister-roboto
Copy link

@wesleybl thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

Wait for page Foo to load before clicking delete.
@wesleybl
Copy link
Member Author

wesleybl commented Oct 9, 2024

@jenkins-plone-org please run jobs

@wesleybl
Copy link
Member Author

wesleybl commented Oct 9, 2024

@jenkins-plone-org please run jobs

@petschki
Copy link
Member

petschki commented Oct 9, 2024

I would not spend much time in fixing selenium tests.

there was much effort the last days in porting all tests to playwright here #4019 ... when we have a running rfbrowser on jenkins again we will test and merge this and then the robottests should be much more stable in general.

@wesleybl wesleybl closed this Oct 9, 2024
@wesleybl wesleybl deleted the linkintegrity_robot branch October 9, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants