Return an error when trying to access the pas views from the web #95
Conversation
|
@ale-rt thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
|
The failing jobs are not present anymore: |
|
Thanks @gforcada |
| @@ -38,3 +39,6 @@ def hasOpenIDExtractor(self): | |||
| def hasOpenIDdExtractor(self): | |||
| # BBB Keeping method name with typo for backwards compatibility. | |||
| return self.hasOpenIDExtractor() | |||
|
|
|||
| def __call__(self): | |||
| raise HTTPImATeapot("View not callable") | |||
There was a problem hiding this comment.
Well, it is not a Teapot but a CMS, so no RFC conform usage here!
https://www.rfc-editor.org/rfc/rfc2324#section-2.3.2
The HTTP 418 I'm a teapot status response code indicates that the server refuses to brew coffee because it is, permanently, a teapot. A combined coffee/tea pot that is temporarily out of coffee should instead return 503.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/418
There was a problem hiding this comment.
If you want another status code to be returned, tell me and I will change it.
The important thing is to stop these views to be accessible from the web.
Alternative for #94
Merge together:
plone/plone.app.users#133
#95
plone/plone.app.querystring#157