adjust image names for gitlab

plone · Oct 14, 2024 · 4df2d9f · 4df2d9f
1 parent 7b71678
commit 4df2d9f
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 5 deletions.
diff --git a/project/{{ cookiecutter.__folder_name }}/devops/stacks/{{ cookiecutter.hostname }}.yml b/project/{{ cookiecutter.__folder_name }}/devops/stacks/{{ cookiecutter.hostname }}.yml
@@ -100,9 +100,9 @@ services:
   varnish:
   {%- if cookiecutter.devops_gitlab_deploy %}
     image: {{ cookiecutter.__container_image_prefix }}/varnish:${STACK_PARAM:-latest}
-  {% else %}
+  {%- else %}
     image: {{ cookiecutter.__container_image_prefix }}-varnish:${STACK_PARAM:-latest}
-  {% endif %}
+  {%- endif %}
     command:
       - '-p'
       - 'nuke_limit=2000'
@@ -140,9 +140,9 @@ services:
   frontend:
   {%- if cookiecutter.devops_gitlab_deploy %}
     image: {{ cookiecutter.__container_image_prefix }}/frontend:${STACK_PARAM:-latest}
-  {% else %}
+  {%- else %}
     image: {{ cookiecutter.__container_image_prefix }}-frontend:${STACK_PARAM:-latest}
-  {% endif %}
+  {%- endif %}
     environment:
       RAZZLE_INTERNAL_API_PATH: http://backend:8080/Plone
       RAZZLE_API_PATH: https://{{ cookiecutter.hostname }}

diff --git a/sub/project_settings/{{ cookiecutter.__folder_name }}/backend/Makefile b/sub/project_settings/{{ cookiecutter.__folder_name }}/backend/Makefile
@@ -127,13 +127,20 @@ test-coverage: $(BIN_FOLDER)/tox ## run tests with coverage
 # Build Docker images
 .PHONY: build-image
 build-image:  ## Build Docker Images
+	{%- if cookiecutter.devops_gitlab_deploy %}
+	@DOCKER_BUILDKIT=1 docker build . -t $(IMAGE_NAME_PREFIX)/backend:$(IMAGE_TAG) -f Dockerfile --build-arg PLONE_VERSION=$(PLONE_VERSION)
+	{%- else %}
 	@DOCKER_BUILDKIT=1 docker build . -t $(IMAGE_NAME_PREFIX)-backend:$(IMAGE_TAG) -f Dockerfile --build-arg PLONE_VERSION=$(PLONE_VERSION)
-
+	{%- endif %}
 # Acceptance tests
 .PHONY: acceptance-backend-start
 acceptance-backend-start: ## Start backend acceptance server
 	ZSERVER_HOST=0.0.0.0 ZSERVER_PORT=55001 LISTEN_PORT=55001 APPLY_PROFILES="{{ cookiecutter.__package_namespace }}/{{ cookiecutter.__package_name }}:default" CONFIGURE_PACKAGES="plone.restapi,plone.volto,plone.volto.cors,{{ cookiecutter.__package_namespace }}/{{ cookiecutter.__package_name }}" $(BIN_FOLDER)/robot-server plone.app.robotframework.testing.VOLTO_ROBOT_TESTING
 
 .PHONY: acceptance-image-build
 acceptance-image-build:  ## Build Docker Images
+	{%- if cookiecutter.devops_gitlab_deploy %}
+	@DOCKER_BUILDKIT=1 docker build . -t $(IMAGE_NAME_PREFIX)/backend-acceptance:$(IMAGE_TAG) -f Dockerfile.acceptance --build-arg PLONE_VERSION=$(PLONE_VERSION)
+	{%- else %}
 	@DOCKER_BUILDKIT=1 docker build . -t $(IMAGE_NAME_PREFIX)-backend-acceptance:$(IMAGE_TAG) -f Dockerfile.acceptance --build-arg PLONE_VERSION=$(PLONE_VERSION)
+	{%- endif %}
diff --git a/sub/project_settings/{{ cookiecutter.__folder_name }}/frontend/Makefile b/sub/project_settings/{{ cookiecutter.__folder_name }}/frontend/Makefile
@@ -24,7 +24,11 @@ DOCKER_IMAGE=plone/server-dev:${PLONE_VERSION}
 DOCKER_IMAGE_ACCEPTANCE=plone/server-acceptance:${PLONE_VERSION}
 
 ADDON_NAME='{{ cookiecutter.__npm_package_name }}'
+{%- if cookiecutter.devops_gitlab_deploy %}
+IMAGE_NAME={{cookiecutter.__container_image_prefix}}/frontend
+{%- else %}
 IMAGE_NAME={{cookiecutter.__container_image_prefix}}-frontend
+{%- endif %}
 IMAGE_TAG=latest
 VOLTO_VERSION = $(shell cat ./mrs.developer.json | python -c "import sys, json; print(json.load(sys.stdin)['core']['tag'])")