Fix pnpm in CI. Missing settings/commands

plone · May 24, 2024 · 78a2786 · 78a2786
1 parent 32640e8
commit 78a2786
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/project/{{ cookiecutter.__folder_name }}/.github/workflows/frontend.yml b/project/{{ cookiecutter.__folder_name }}/.github/workflows/frontend.yml
@@ -46,13 +46,8 @@ jobs:
         with:
           node-version: {{ "${{ env.NODE_VERSION }}" }}
 
-      - uses: pnpm/action-setup@{{ cookiecutter.__gha_version_setup_pnpm }}
-        name: Install pnpm
-        with:
-          version: 9
-          # We don't want to install until later,
-          # when the cache is in place
-          run_install: false
+      - name: Enable corepack
+        run: corepack enable
 
       - name: Get pnpm store directory
         shell: bash

diff --git a/sub/project_settings/{{ cookiecutter.__folder_name }}/frontend/Makefile b/sub/project_settings/{{ cookiecutter.__folder_name }}/frontend/Makefile
@@ -51,6 +51,10 @@ build: ## Build a production bundle for distribution of the project with the add
 i18n: ## Sync i18n
 	pnpm --filter $(ADDON_NAME) i18n
 
+.PHONY: ci-i18n
+ci-i18n: ## Check if i18n is not synced
+	pnpm --filter $(ADDON_NAME) i18n && git diff -G'^[^\"POT]' --exit-code
+
 .PHONY: format
 format: ## Format codebase
 	pnpm lint:fix
@@ -61,7 +65,7 @@ format: ## Format codebase
 lint: ## Lint, or catch and remove problems, in code base
 	pnpm lint
 	pnpm prettier
-	pnpm stylelint
+	pnpm stylelint --allow-empty-input
 
 .PHONY: release
 release: ## Release the add-on on npmjs.org