Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Steve Piercy <[email protected]>
  • Loading branch information
ericof and stevepiercy authored May 28, 2024
1 parent 9f86fc0 commit 8f93370
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions backend_addon/{{ cookiecutter.__folder_name }}/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ install: build-dev ## Install Plone
build: build-dev ## Install Plone

.PHONY: clean
clean: ## Cleanup environment
clean: ## Clean environment
@echo "$(RED)==> Cleaning environment and build$(RESET)"
rm -rf $(VENV_FOLDER) pyvenv.cfg .installed.cfg instance .tox .venv .pytest_cache

Expand All @@ -88,7 +88,7 @@ create-site: instance/etc/zope.ini ## Create a new site from scratch
PYTHONWARNINGS=ignore $(BIN_FOLDER)/zconsole run instance/etc/zope.conf ./scripts/create_site.py

.PHONY: check
check: $(BIN_FOLDER)/tox ## Check (and fix) codebase according to our standards
check: $(BIN_FOLDER)/tox ## Check and fix code base according to Plone standards
@echo "$(GREEN)==> Format codebase$(RESET)"
$(BIN_FOLDER)/tox -e lint

Expand Down
2 changes: 1 addition & 1 deletion project/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ You can use some of its options to avoid repeatedly entering the same values.

#### `--no_input`

You can use the [`--no_input`](https://cookiecutter.readthedocs.io/en/latest/cli_options.html#cmdoption-cookiecutter-no-input) option to make the cookieplone not prompt for parameters and only use `cookiecutter.json` file content.
You can use the [`--no_input`](https://cookiecutter.readthedocs.io/en/latest/cli_options.html#cmdoption-cookiecutter-no-input) option to make cookieplone not prompt for parameters and only use `cookiecutter.json` file content.


#### `--replay` and `--replay-file`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ install: build-dev ## Install Plone
build: build-dev ## Install Plone

.PHONY: clean
clean: ## Cleanup environment
clean: ## Clean environment
@echo "$(RED)==> Cleaning environment and build$(RESET)"
rm -rf $(VENV_FOLDER) pyvenv.cfg .installed.cfg instance .tox .venv .pytest_cache

Expand All @@ -101,7 +101,7 @@ update-example-content: $(BIN_FOLDER)/tox ## Export example content inside packa
$(BIN_FOLDER)/plone-exporter instance/etc/zope.conf $(PLONE_SITE_ID) $(EXAMPLE_CONTENT_FOLDER)

.PHONY: check
check: $(BIN_FOLDER)/tox ## Check (and fix) codebase according to our standards
check: $(BIN_FOLDER)/tox ## Check and fix code base according to Plone standards
@echo "$(GREEN)==> Format codebase$(RESET)"
$(BIN_FOLDER)/tox -e lint

Expand Down

0 comments on commit 8f93370

Please sign in to comment.