Remove @plone/components from deps, on release it is complex to han…

…dle, we will do it when it really matters. Fix also version sync script on release
plone · Jun 11, 2024 · ecc2968 · ecc2968
1 parent fa9243f
commit ecc2968
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/...ecutter.__folder_name }}/packages/{{ cookiecutter.frontend_addon_name }}/.release-it.json b/...ecutter.__folder_name }}/packages/{{ cookiecutter.frontend_addon_name }}/.release-it.json
@@ -4,7 +4,7 @@
       "pipx run towncrier build --draft --yes --version ${version} > .changelog.draft",
       "pipx run towncrier build --yes --version ${version}",
       "cp ../../README.md ./ && cp CHANGELOG.md ../../CHANGELOG.md",
-      "python3 -c 'import json; data = json.load(open(\"../../package.json\")); data[\"version\"] = ${version}; json.dump(data, open(\"../../package.json\", \"w\"), indent=2)'",
+      "python3 -c 'import json; data = json.load(open(\"../../package.json\")); data[\"version\"] = \"${version}\"; json.dump(data, open(\"../../package.json\", \"w\"), indent=2)'",
       "git add ../../CHANGELOG.md ../../package.json"
     ],
     "after:release": "rm .changelog.draft README.md"

diff --git a/...ookiecutter.__folder_name }}/packages/{{ cookiecutter.frontend_addon_name }}/package.json b/...ookiecutter.__folder_name }}/packages/{{ cookiecutter.frontend_addon_name }}/package.json
@@ -26,9 +26,7 @@
     "release-major-alpha": "release-it major --preRelease=alpha",
     "release-alpha": "release-it --preRelease=alpha"
   },
-  "dependencies": {
-    "@plone/components": "{{ cookiecutter.__version_plone_components }}"
-  },
+  "dependencies": {},
   "peerDependencies": {
     "react": "18.2.0",
     "react-dom": "18.2.0",