Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes #28

Merged
merged 5 commits into from
May 29, 2024
Merged

Misc fixes #28

merged 5 commits into from
May 29, 2024

Conversation

sneridagh
Copy link
Member

see commits

sneridagh added 5 commits May 29, 2024 20:27
* issue-2-project-template:
  Remove trove classifier of distribution from project_settings
  Flag to add distribution trove classifier
  Backend: Update .dockerignore
  Apply suggestions from code review
  Fix Makefile and README
  Improve template testing with newer cookieplone version (0.7.0)
  Add dependabot.yml
@sneridagh sneridagh requested a review from ericof as a code owner May 29, 2024 18:38
@ericof ericof merged commit ea16d2d into issue-2-project-template May 29, 2024
19 checks passed
@ericof ericof deleted the sneridagh-misc-fixes branch May 29, 2024 20:32
ericof added a commit that referenced this pull request Jun 7, 2024
…es (#18)

* Implement cookiecutter-plone-starter templates in cookieplone-templates

* Fix GHA for project

* Add .env_gha file

* Improve project generation

* Remove one layer in the backend folder

* Fix project generation

* Lint fixes

* Add newly created files to the repository

* Pre-format codebase during generation

* Improvements from moving sneridagh.dev to the new setup (#20)

* knowledge from moving sneridagh.dev to the new setup

* Better now

* Try to fix tests

* Finally

* Fix Readme RST in backend

* No pnpm action anymore

* Fix pnpm in CI. Missing settings/commands

* update instance.yaml to not dup defaults and update zcml style to non deprecated

* fix author name in CONTRIBUTIONS

* -mupdate makefile , use .venv and some vars

* Missing fixed package name from tests

* start fixed

* Use uv for package installation, include example content

* Add dependabot.yml

* Improve template testing with newer cookieplone version (0.7.0)

* Fix Makefile and README

* Apply suggestions from code review

Co-authored-by: Steve Piercy <[email protected]>

* Backend: Update .dockerignore

* Flag to add distribution trove classifier

* Remove trove classifier of distribution from project_settings

* Misc fixes (#28)

* Update docker_build_push GHA to v5

* Fix use case where you are building image with a previous local build

* Fix redundant VOLTO_VERSION and PLONE_VERSION in Makefile

* Missing command

* Fix typos

* no need to install restapi here, plone.volto already takes care of it

* Makefile improvements (#29)

* First round of Makefile command improvements for projects

* Fix hardcoded package name

* Fix tests for project generation

* Add new public directory to project (#31)

* Update `volto.config.js` for support `publicPath` (#32)

* Latest updates to the volto PR supporting `public` folders per add-on (#33)

* Improve linting, and polish start/build/install scripts (#34)

* pre-commit for frontend (#23)

* Fix paths for GHA, commands for acceptance, fix README references to commands (#30)

* Fix paths for GHA, fix README references to commands

* Fix acceptance test command

* Update @plone/components version to grab the one in the monorepo

* Fix releaser in frontend_addon template

* Build deps on install

* Remove build deps from scripts

---------

Co-authored-by: Víctor Fernández de Alba <[email protected]>
Co-authored-by: Jens W. Klein <[email protected]>
Co-authored-by: Steve Piercy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants