Fix paths for GHA, commands for acceptance, fix README references to commands #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sneridagh
commented
Jun 3, 2024
| @@ -5,6 +5,7 @@ on: | |||
| - "*.js" | |||
| - "*.json" | |||
| - "*.yaml" | |||
| - "*.yml" | |||
There was a problem hiding this comment.
@ericof why *.yaml? Did you want to point to .github/workflows/*.yml? if so, they are not triggering, I would point each related *.yml in each workflow. What do you think?
stevepiercy
approved these changes
Jun 3, 2024
sneridagh
commented
Jun 4, 2024
...okiecutter.__folder_name }}/packages/{{ cookiecutter.frontend_addon_name }}/.release-it.json
Show resolved
Hide resolved
sneridagh
commented
Jun 4, 2024
|
@ericof could be that we have some tests that are flakey in the backend? https://github.com/plone/cookieplone-templates/actions/runs/9365961831/job/25782344574 see previous and next ones... they do pass. |
ericof
reviewed
Jun 7, 2024
|
@ericof we would need to have a quick talk before this one |
ericof
added a commit
that referenced
this pull request
Jun 7, 2024
…es (#18) * Implement cookiecutter-plone-starter templates in cookieplone-templates * Fix GHA for project * Add .env_gha file * Improve project generation * Remove one layer in the backend folder * Fix project generation * Lint fixes * Add newly created files to the repository * Pre-format codebase during generation * Improvements from moving sneridagh.dev to the new setup (#20) * knowledge from moving sneridagh.dev to the new setup * Better now * Try to fix tests * Finally * Fix Readme RST in backend * No pnpm action anymore * Fix pnpm in CI. Missing settings/commands * update instance.yaml to not dup defaults and update zcml style to non deprecated * fix author name in CONTRIBUTIONS * -mupdate makefile , use .venv and some vars * Missing fixed package name from tests * start fixed * Use uv for package installation, include example content * Add dependabot.yml * Improve template testing with newer cookieplone version (0.7.0) * Fix Makefile and README * Apply suggestions from code review Co-authored-by: Steve Piercy <[email protected]> * Backend: Update .dockerignore * Flag to add distribution trove classifier * Remove trove classifier of distribution from project_settings * Misc fixes (#28) * Update docker_build_push GHA to v5 * Fix use case where you are building image with a previous local build * Fix redundant VOLTO_VERSION and PLONE_VERSION in Makefile * Missing command * Fix typos * no need to install restapi here, plone.volto already takes care of it * Makefile improvements (#29) * First round of Makefile command improvements for projects * Fix hardcoded package name * Fix tests for project generation * Add new public directory to project (#31) * Update `volto.config.js` for support `publicPath` (#32) * Latest updates to the volto PR supporting `public` folders per add-on (#33) * Improve linting, and polish start/build/install scripts (#34) * pre-commit for frontend (#23) * Fix paths for GHA, commands for acceptance, fix README references to commands (#30) * Fix paths for GHA, fix README references to commands * Fix acceptance test command * Update @plone/components version to grab the one in the monorepo * Fix releaser in frontend_addon template * Build deps on install * Remove build deps from scripts --------- Co-authored-by: Víctor Fernández de Alba <[email protected]> Co-authored-by: Jens W. Klein <[email protected]> Co-authored-by: Steve Piercy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.