Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @plone/components from deps, on release it is complex to han… #38

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Remove @plone/components from deps, on release it is complex to han… #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecc2968
Remove `@plone/components` from deps, on release it is complex to han…
sneridagh Jun 11, 2024
3d0da98
Remove unused variable
sneridagh Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion frontend_addon/cookiecutter.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"__npm_package_name": "{{ cookiecutter.npm_package_name }}",
"__version_package": "1.0.0-alpha.0",
"__version_plone_volto": "{{ cookiecutter.volto_version }}",
"__version_plone_components": "workspace:*",
"__version_plone_scripts": "^3.6.1",
"__version_mrs_developer": "^2.2.0",
"__version_pnpm": "9.1.1",
Expand Down
2 changes: 1 addition & 1 deletion ...ecutter.__folder_name }}/packages/{{ cookiecutter.frontend_addon_name }}/.release-it.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"pipx run towncrier build --draft --yes --version ${version} > .changelog.draft",
"pipx run towncrier build --yes --version ${version}",
"cp ../../README.md ./ && cp CHANGELOG.md ../../CHANGELOG.md",
"python3 -c 'import json; data = json.load(open(\"../../package.json\")); data[\"version\"] = ${version}; json.dump(data, open(\"../../package.json\", \"w\"), indent=2)'",
"python3 -c 'import json; data = json.load(open(\"../../package.json\")); data[\"version\"] = \"${version}\"; json.dump(data, open(\"../../package.json\", \"w\"), indent=2)'",
"git add ../../CHANGELOG.md ../../package.json"
],
"after:release": "rm .changelog.draft README.md"
Expand Down
4 changes: 1 addition & 3 deletions ...ookiecutter.__folder_name }}/packages/{{ cookiecutter.frontend_addon_name }}/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@
"release-major-alpha": "release-it major --preRelease=alpha",
"release-alpha": "release-it --preRelease=alpha"
},
"dependencies": {
"@plone/components": "{{ cookiecutter.__version_plone_components }}"
},
"dependencies": {},
"peerDependencies": {
"react": "18.2.0",
"react-dom": "18.2.0",
Expand Down