-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the official pnpm
based images
#58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will only work if VOLTO_VERSION is 18.0.0-alpha.43 or later, right?
@davisagli ufff, yes... would anybody use Cookieplone and choose an alpha version that is not the last one? And final is near... |
@davisagli In the meanwhile, Cookieplone get the images from the ones that the kitconcept repo PR generates... which inherently is bad and forces us to release there a43 too. I would merge this asap. I would write a post to the community forums, to make people notice of the change. Overall, Cookieplone was experimental until that we decide that it will be the default in Plone 6.1/Volto 18, so everybody that used it has to adjust to latest anyways... it's like when you use an alpha, then there's a final version. |
I want to slam on the brakes for two reasons:
|
@stevepiercy I'm doing some testing before commenting here, but for now I'll say:
I wasn't aware of the discussion on Discord, so I'll have to catch up with that as well. But no brake slamming needed here from my point of view. This PR is about fixing the current image used by cookieplone-templates, not about the efforts to recommend it as a default. |
@sneridagh I agree we should go ahead and merge this, but it made me realize that the cookieplone templates don't work with older versions of Volto, which I wasn't aware or had forgotten. This means we'll need to do a much better job of communicating when people can use cookieplone. i.e.
|
@sneridagh OK, that makes sense. @davisagli for docs, we need to maintain everything that works with supported versions of Plone, so we'll need two sets of docs for creating a project with Volto. I think we'll need separate pages, or possibly a synchronized tabbed interface thanks to Sphinx Design. I'm wary of the length, but with synchronization, it might be OK. |
@stevepiercy I agree both with the need and with your wariness about it. I wish we could make a cleaner cut over to a new set of instructions, but the changes are all tied up in the switch to a different way of organizing the frontend code, which only works in Volto 18 and beyond. I will help with this. |
No description provided.