Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the official pnpm based images #58

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

sneridagh
Copy link
Member

No description provided.

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only work if VOLTO_VERSION is 18.0.0-alpha.43 or later, right?

@sneridagh
Copy link
Member Author

@davisagli ufff, yes... would anybody use Cookieplone and choose an alpha version that is not the last one? And final is near...
We could put logic in CookiePlone itself for account for this, but would it be worth it?

@sneridagh
Copy link
Member Author

@davisagli In the meanwhile, Cookieplone get the images from the ones that the kitconcept repo PR generates... which inherently is bad and forces us to release there a43 too. I would merge this asap.

I would write a post to the community forums, to make people notice of the change.

Overall, Cookieplone was experimental until that we decide that it will be the default in Plone 6.1/Volto 18, so everybody that used it has to adjust to latest anyways... it's like when you use an alpha, then there's a final version.

@stevepiercy
Copy link
Contributor

@davisagli
Copy link
Member

davisagli commented Sep 14, 2024

@stevepiercy I'm doing some testing before commenting here, but for now I'll say:

  1. Merging this makes cookieplone-templates better, not worse (it already does not work with volto 16 and 17, and at the moment it does not work with volto 18 until we merge this)
  2. We're fully aware that docs are needed, and we need to time that carefully with the final release of Volto 18. I need to catch up with your flurry of issues & PRs from yesterday, and I'm hosting some people today so won't have time to look carefully until later.

I wasn't aware of the discussion on Discord, so I'll have to catch up with that as well.

But no brake slamming needed here from my point of view. This PR is about fixing the current image used by cookieplone-templates, not about the efforts to recommend it as a default.

@davisagli
Copy link
Member

@sneridagh I agree we should go ahead and merge this, but it made me realize that the cookieplone templates don't work with older versions of Volto, which I wasn't aware or had forgotten. This means we'll need to do a much better job of communicating when people can use cookieplone. i.e.

  1. It's misleading that cookieplone prompts for a Volto version and accepts older versions, but they don't work. We should validate the version there or at least give some help text about what is supported.
  2. When we update docs to explain how to create a project with cookieplone, we have to explain that it's for Volto 18 only, and refer people to cookiecutter-plone-starter if they need to generate a project with an older version.

@stevepiercy
Copy link
Contributor

@sneridagh OK, that makes sense.

@davisagli for docs, we need to maintain everything that works with supported versions of Plone, so we'll need two sets of docs for creating a project with Volto. I think we'll need separate pages, or possibly a synchronized tabbed interface thanks to Sphinx Design. I'm wary of the length, but with synchronization, it might be OK.

@davisagli
Copy link
Member

@stevepiercy I agree both with the need and with your wariness about it. I wish we could make a cleaner cut over to a new set of instructions, but the changes are all tied up in the switch to a different way of organizing the frontend code, which only works in Volto 18 and beyond.

I will help with this.

@sneridagh sneridagh merged commit fa4eb18 into main Sep 16, 2024
6 checks passed
@sneridagh sneridagh deleted the useofficialpnpmimages branch September 16, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants