-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release distribution #192
base: main
Are you sure you want to change the base?
Release distribution #192
Conversation
This is not what I want for my packages, but it is what I usually have (fullrelease locally) so I'm very happy 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good feature, lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See suggested change.
Other than that, it should be fine.
But I won't use it myself for core Plone packages: I release those within a checkout of the coredev buildout, and make a release by doing ../../bin/fullrelease
.
description = create a new release | ||
skip_install = true | ||
deps = | ||
zest.release[recommended] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in zest.releaser
. And we should add two that are not in the recommended list:
zest.release[recommended] | |
zest.releaser[recommended] | |
zest.pocompile | |
zestreleaser.towncrier |
Install and run `zest.releaser`'s `fullrelease` command to generate, and upload a new release of the distribution.
8571ec1
to
dcf3438
Compare
Partially is #100 but it does simply install and call
fullrelease
fromzest.releaser
.This way, it all still happens locally... from a security point of view, maybe that's best? Otherwise any random developer can do:
git clone https://github.com/plone/plone.batching cd plone.batching tox -e release
💥
Do we want that? 🤔
If we only call
fullrelease
ontox -e release
if you don't have upload permissions on PyPI the release is not uploaded. 🩹This together with the #187 it will create both releases on PyPI but also on GitHub 🎉
And if we expand mr.roboto(?) to monitor releases in GitHub, we can map new Plone distributions' releases with in which Plone version they are used (i.e.
plone.batching
new release should be added to both Plone6.0
and6.1
).At the end that would be to (partially) merge
plone.releaser
tomr.roboto
.@mauritsvanrees not sure how comfortable you would be with this change, and if that makes sense at all 🤔
The grand idea behind all this stepping stones is to distribute the load to create new releases while at the same time keep all those new versions finding their way to the right Plone version.
I'm thinking about refactoring code, for example, one needs to wait for the other distribution to be released with the code that has been moved there, to be able to depend on it.
If a new release on the first distribution finds its way on the
plone-6xx-dev.txt
requirements file, then we can depend on these files being updated automatically upon a new release.@davisagli @jensens @ericof (and others of course!) opinions? Probably we should move this to community.plone.org?