fix(pat relateditems): Import Select2 module before calling it when not yet initialized

[frapell]

This PR fixes gh-1341

[frapell]

@thet Mind taking a look at this if you have some time? My understanding is that the new operator doesn't return a promise, so it cannot be awaited... My first approach at fixing this issue was to add an await in

mockup/src/pat/tinymce/js/links.js

Line 101 in c9d330a

this.relatedItems = new RelatedItems(this.getEl(), options);

but that doesn't work and

mockup/src/pat/tinymce/js/links.js

Line 109 in c9d330a

this.relatedItems.selectItem(val);

gets called with the select2 module not yet available.

I don't like my solution very much, but I believe a proper solution would require extensive refactoring, and could potentially break in unexpected places...

Thoughts?

[thet]

Hi, I think using the await_pattern_init from Patternslib should work.
Import:

import events from "@patternslib/patternslib/src/core/events";

then:

createRelatedItems: async function () {
    [...]
    this.relatedItems = new RelatedItems(this.getEl(), options);
    await events.await_pattern_init(this.relatedItems)
}

There should be many examples in Patternslib.

Hope that helps!

I'm happy to review this later.

[frapell]

@thet Thank you for that! had no idea about the await_pattern_init and I think it is a better solution. I force pushed the commit replacing the previous one to avoid excessive commits

[frapell]

@thet I included my latest commit into this PR, which is totally unrelated to this fix, but I think it is a nice to have. Right now, it is not possible to add the "Insert Link" or "Insert Image" to the menu, they can only be added as buttons to the toolbar.
I added calls to addMenuItem for them (https://www.tiny.cloud/docs/tinymce/6/apis/tinymce.editor.ui.registry/#addMenuItem) and now you can add those actions to the menu:

Let me know if you want me to revert it and submit a separate PR for that

[thet]

LGTM.

regarding the add image/add link in the insert menu - totally fine for me.
But you have this commit message: "Include ability to add the insert image and insert link in the insert menu". Shouldn't it be: "Include the insert image and insert link in the insert menu"? Because you aren't adding a ability but the menu items itself, right?

[frapell]

@thet No, you still need to add ploneimage and plonelink to the JSON config for the menu in /@@tinymce-controlpanel. What happens today without this code change is that if you cannot have the buttons showing up in the menu, even adding those entries to the config.
By config I mean something like this:

    "insert": {
        "title": "Insert",
        "items": "ploneimage plonelink media inserttable | charmap | anchor | insertdatetime"
    },