Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated image node when updateing already inserted image. [5.1.x] #1370

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

petschki
Copy link
Member

@petschki petschki requested review from pbauer and thet February 26, 2024 20:59
@petschki petschki force-pushed the tinymce-imagemodal-fix-5.1.x branch from a4084ba to 48e1852 Compare February 26, 2024 21:22
@pbauer
Copy link
Member

pbauer commented Feb 27, 2024

How do I test that? I forgot how to get Plone to use the raw js instead of the minified bundle.

@petschki
Copy link
Member Author

  1. checkout mockup
  2. run yarn install && yarn start:webpack inside the package
  3. in the resource controlpanel go to the plone bundle and use http://localhost:8000/bundle.min.js as javascript resource

@pbauer
Copy link
Member

pbauer commented Feb 27, 2024

I tested plone/plone.staticresources#323 with 6.1 and it worked.

yarn start:webpack did not work:

mockup git:(5.1.x) $ yarn start:webpack
command not found: webpack`

@petschki
Copy link
Member Author

yarn start:webpack did not work:

hm ... strange. maybe this is because of yarn version ... mockup only runs in yarn < 2

I'll prepare releases now for the fix.

@petschki petschki merged commit 964bc61 into 5.1.x Feb 27, 2024
2 checks passed
@petschki petschki deleted the tinymce-imagemodal-fix-5.1.x branch February 27, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants