Skip to content

Commit

Permalink
Merge pull request #125 from plone/remove-plone-app-iterate-profile
Browse files Browse the repository at this point in the history
Remove old GenericSetup profile with id `plone.app.iterate`.
  • Loading branch information
mauritsvanrees authored Jun 15, 2024
2 parents aaa5472 + ff32b3f commit f6af29e
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 29 deletions.
3 changes: 3 additions & 0 deletions news/99.breaking
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Remove old GenericSetup profile with id `plone.app.iterate`.
See `issue 99 <https://github.com/plone/plone.app.iterate/issues/99#issuecomment-1484686642>`_.
[maurits]
14 changes: 0 additions & 14 deletions plone/app/iterate/configure.zcml
Original file line number Diff line number Diff line change
Expand Up @@ -57,20 +57,6 @@
directory="profiles/default"
/>

<!--
The plone.app.iterate:plone.app.iterate profile is deprecated.
Remove either in Plone 6.1 or 7.0, I am on the fence here.
See https://github.com/plone/plone.app.iterate/issues/99#issuecomment-1484686642
-->
<genericsetup:registerProfile
name="plone.app.iterate"
title="Working Copy Support (Iterate)"
description="Adds working copy support (aka. in-place staging) to Plone."
provides="Products.GenericSetup.interfaces.EXTENSION"
directory="profiles/default"
post_handler=".setuphandlers.deprecate_profile"
/>

<genericsetup:registerProfile
name="test"
title="plone.app.iterate: Test fixture"
Expand Down
14 changes: 0 additions & 14 deletions plone/app/iterate/setuphandlers.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
from plone.base.interfaces.installable import INonInstallable
from zope.interface import implementer

import warnings


@implementer(INonInstallable)
class HiddenProfiles:
Expand All @@ -13,17 +11,5 @@ def getNonInstallableProfiles(self):
"""
return [
"plone.app.iterate:uninstall",
"plone.app.iterate:plone.app.iterate",
"plone.app.iterate:to1000",
]


def deprecate_profile(tool):
"""Deprecation profile plone.app.iterate.
Deprecation warning for plone.app.iterate:plone.app.iterate profile.
"""
warnings.warn(
'The profile with id "plone.app.iterate" was renamed to "default".',
DeprecationWarning,
)
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from setuptools import setup


version = "5.0.6.dev0"
version = "6.0.0.dev0"

long_description = (
f"{Path('README.rst').read_text()}\n{Path('CHANGES.rst').read_text()}"
Expand Down

0 comments on commit f6af29e

Please sign in to comment.