Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plone6 styles #114

Merged
merged 5 commits into from
Feb 19, 2024
Merged

Plone6 styles #114

merged 5 commits into from
Feb 19, 2024

Conversation

spereverde
Copy link
Sponsor Member

Adding only the style changes from #96
Since @davisagli asked to seperate out the permission changes
We'd love to have this update in in a next release since without it the statusmessages look pretty bad, or at least unstyled :-)

@mister-roboto
Copy link

@spereverde thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@spereverde
Copy link
Sponsor Member Author

AT first sight it didn't seem that any of the permission changes were necessary for the style update, so I left all permission related commits form the plone6 branch out for now
@pbauer, @davisagli let me know if that is wrong, I can cherry-pick the needed ones

@gforcada gforcada requested review from pbauer and removed request for gforcada November 14, 2023 07:56
@gforcada
Copy link
Sponsor Member

@spereverde you probably wanted to request a review from @pbauer rather from me :)

@spereverde
Copy link
Sponsor Member Author

@gforcada github suggested you, I guess because you made the last commits, I will add Philip as a reviewer, thx

@davisagli
Copy link
Sponsor Member

@spereverde I tested this. It's an improvement but the status message looks too wide:

Screenshot 2023-11-26 at 3 42 12 PM

Probably it needs to go inside a <div class="container">

@spereverde
Copy link
Sponsor Member Author

spereverde commented Nov 27, 2023

@davisagli I admit I didn't recheck visually on a clean setup, I'll amend a fix and let you know

@laulaz
Copy link
Member

laulaz commented Feb 7, 2024

@davisagli I admit I didn't recheck visually on a clean setup, I'll amend a fix and let you know

Hey Kim ! are you still planning to work on this one ?

@spereverde
Copy link
Sponsor Member Author

@davisagli I admit I didn't recheck visually on a clean setup, I'll amend a fix and let you know

Hey Kim ! are you still planning to work on this one ?

apparently I forgot :-)
I'd still like to work on this, but won't be able to the next 2 weeks, so feel free to take over if it's urgent for you

@pbauer
Copy link
Sponsor Member

pbauer commented Feb 19, 2024

I rebased the changes and wrapped the messages in a container

@pbauer
Copy link
Sponsor Member

pbauer commented Feb 19, 2024

@jenkins-plone-org please run jobs

@pbauer pbauer merged commit f37417f into master Feb 19, 2024
12 checks passed
@pbauer pbauer deleted the plone6-styles branch February 19, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants