Allows working copy of Plone Site - 5.x #128
Conversation
The container for the Plone Site working copy is Plone Site itself. To avoid permission errors, the Plone Site working copy is created as the Document type. But right after the Document is created, its portal_type is changed to "Plone Site", so that the schema of the working copy is the same as the Plone Site schema. - Prevents Plone Site permissions from being changed on checkin.
The working copy of Plone Site is created in Plone Site itself. So at checkout, we should check if the user has permission to add content in Plone Site, instead of its parent.
Plone Site is now versionable in Products.CMFEditions
|
@wesleybl thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
wesleybl
changed the title
|
I ran the tests for this PR along with plone/Products.CMFEditions#113 See: |
|
For the tests to pass, it is also necessary to test with: plone/plone.app.versioningbehavior#87 I started testing Plone 6.0 with the 3 PRs |
wesleybl
force-pushed
the
working_copy_portal_5.x
branch
from
32a4ead
to
afd1996
Compare
|
@jenkins-plone-org please run jobs |
|
I removed tests that I had inserted, so that this PR works without the need for others. |
This is part of: plone/volto#5284
The container for the Plone Site working copy is Plone Site itself.
To avoid permission errors, the Plone Site working copy is created as the Document type. But right after the Document is created, its
portal_typeis changed to "Plone Site", so that the schema of the working copy is the same as the Plone Site schema.Prevents Plone Site permissions from being changed on checkin.
The working copy of Plone Site is created in Plone Site itself. So at checkout, we should check if the user has permission to add content in Plone Site, instead of its parent.