Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move plone locking info to plone app layout #384

Conversation

cihanandac
Copy link
Contributor

@cihanandac cihanandac commented Feb 10, 2025

@mister-roboto
Copy link

@cihanandac thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@ale-rt
Copy link
Member

ale-rt commented Feb 10, 2025

@jenkins-plone-org please run jobs

@ale-rt
Copy link
Member

ale-rt commented Feb 10, 2025

@jenkins-plone-org please run jobs

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename info.pt/py to locking.pt/py please?

@mauritsvanrees
Copy link
Member

I have made maintenance branches for plone.app.layout and plone.locking and have updated coredev 6.1 to use them.

@cihanandac cihanandac force-pushed the 3953-move-plone-locking-info-to-plone-app-layout branch from 92776be to e87849b Compare February 11, 2025 14:23
@cihanandac
Copy link
Contributor Author

  • Renamed info.py/pt to locking.py/pt
  • Removed the redundant comment
  • Utilized the relative notion for the configure.zcml

Thanks for all the suggestions @mauritsvanrees, @petschki

@cihanandac cihanandac force-pushed the 3953-move-plone-locking-info-to-plone-app-layout branch from e87849b to 43d216c Compare February 11, 2025 14:29
@cihanandac cihanandac force-pushed the 3953-move-plone-locking-info-to-plone-app-layout branch from 43d216c to 792a812 Compare February 11, 2025 15:05
@mauritsvanrees
Copy link
Member

Thanks! I merged this one and your accompanying plone.locking PR.

@mauritsvanrees mauritsvanrees merged commit 319dcc0 into plone:master Feb 12, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants