-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move plone locking info to plone app layout #384
Move plone locking info to plone app layout #384
Conversation
@cihanandac thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename info.pt/py
to locking.pt/py
please?
I have made maintenance branches for plone.app.layout and plone.locking and have updated coredev 6.1 to use them. |
92776be
to
e87849b
Compare
Thanks for all the suggestions @mauritsvanrees, @petschki |
e87849b
to
43d216c
Compare
43d216c
to
792a812
Compare
Thanks! I merged this one and your accompanying |
Note by @ale-rt:
Before merging we need a PR that removes the moved code from plone.app.layout
Requires:
Refs: