Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

122 portrait image file not supported by pil #123

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

rber474
Copy link
Member

@rber474 rber474 commented Feb 23, 2024

Added a validation in the @@personal-information form for the portrait field.
If image is not supported by pillow an validation error will be shown.

@erral I haven't added any translations to plone.app.locales because I am not sure what the workflow is.

Running test I was getting an error for the tearDown so added a transaction.commit to setUp in BaseTest.

Please, review it and let me know if I wrong.

@mister-roboto
Copy link

@rber474 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@erral
Copy link
Member

erral commented Feb 23, 2024

I will handle the translation update in p.a.locales.

The worklfow is a bit different and it is handled at the same time for all packages. Thanks for the heads up!

@rber474
Copy link
Member Author

rber474 commented Feb 23, 2024

@jenkins-plone-org please run jobs

@rber474
Copy link
Member Author

rber474 commented Feb 23, 2024

I am not sure the failed Jenkins test is related to this change:

{'en': <Document at /plone/en/test-document>} != {'en': <Document at /plone/en/test-folder/test-document>}

  • {'en': <Document at /plone/en/test-document>}
  • {'en': <Document at /plone/en/test-folder/test-document>}
    ? ++++++++++++

    File "/srv/python3.8/lib/python3.8/unittest/case.py", line 60, in testPartExecutor
    yield
    File "/srv/python3.8/lib/python3.8/unittest/case.py", line 676, in run
    self._callTestMethod(testMethod)
    File "/srv/python3.8/lib/python3.8/unittest/case.py", line 633, in _callTestMethod
    method()
    File "/home/jenkins/.buildout/eggs/cp38/plone.app.multilingual-7.0.3-py3.8.egg/plone/app/multilingual/tests/test_helper_views.py", line 123, in test_move_content_existing_translation_inside
    self.assertEqual(
    File "/srv/python3.8/lib/python3.8/unittest/case.py", line 912, in assertEqual
    assertion_func(first, second, msg=msg)
    File "/srv/python3.8/lib/python3.8/unittest/case.py", line 1211, in assertDictEqual
    self.fail(self._formatMessage(msg, standardMsg))
    File "/srv/python3.8/lib/python3.8/unittest/case.py", line 753, in fail
    raise self.failureException(msg)

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Sorry for letting you wait so long.

@mauritsvanrees mauritsvanrees merged commit ee9ebe9 into master Apr 22, 2024
12 checks passed
@mauritsvanrees mauritsvanrees deleted the 122-portrait-image-file-not-supported-by-pil branch April 22, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid file error while uploading different file format in personal Information admin page.
4 participants