-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
122 portrait image file not supported by pil #123
122 portrait image file not supported by pil #123
Conversation
@rber474 thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
I will handle the translation update in p.a.locales. The worklfow is a bit different and it is handled at the same time for all packages. Thanks for the heads up! |
@jenkins-plone-org please run jobs |
I am not sure the failed Jenkins test is related to this change: {'en': <Document at /plone/en/test-document>} != {'en': <Document at /plone/en/test-folder/test-document>}
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sorry for letting you wait so long.
Added a validation in the @@personal-information form for the portrait field.
If image is not supported by pillow an validation error will be shown.
@erral I haven't added any translations to plone.app.locales because I am not sure what the workflow is.
Running test I was getting an error for the tearDown so added a transaction.commit to setUp in BaseTest.
Please, review it and let me know if I wrong.