Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused and broken member-registration control panel #128

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

mauritsvanrees
Copy link
Member

Fixes #127
See explanation there. Should be fine for Plone 6.0 and 6.1.

This still tried to use the ``portal_properties`` tool.
Since Plone 5.0 the ``member-fields`` control panel is used instead.
@mister-roboto
Copy link

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@mauritsvanrees
Copy link
Member Author

@jenkins-plone-org please run jobs

@jensens jensens merged commit 82bd3d3 into master Jun 7, 2024
13 checks passed
@jensens jensens deleted the remove-portal-properties-tool branch June 7, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove outdated member-registration control panel
3 participants