#187 backport to 2.x #189
#187 backport to 2.x #189
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
@jenkins-plone-org please run jobs |
Backported from version 2.0. This fixes test failures on Plone 5.2 Python 3 when used together with plone/plone.dexterity#189, which is a backport of a memory leak fix. Failures are like this: ``` File "/home/jenkins/.buildout/eggs/cp38/plone.autoform-1.9.1-py3.8.egg/plone/autoform/tests/../autoform.rst", line 50, in autoform.rst Failed example: xmlconfig.xmlconfig(StringIO(configuration)) Exception raised: Traceback (most recent call last): File "/srv/python3.8/lib/python3.8/doctest.py", line 1336, in __run exec(compile(example.source, filename, "single", File "<doctest autoform.rst[11]>", line 1, in <module> xmlconfig.xmlconfig(StringIO(configuration)) File "/home/jenkins/.buildout/eggs/cp38/zope.configuration-4.4.1-py3.8.egg/zope/configuration/xmlconfig.py", line 732, in xmlconfig context.execute_actions(testing=testing) File "/home/jenkins/.buildout/eggs/cp38/zope.configuration-4.4.1-py3.8.egg/zope/configuration/config.py", line 799, in execute_actions reraise( File "/home/jenkins/.buildout/eggs/cp38/zope.configuration-4.4.1-py3.8.egg/zope/configuration/_compat.py", line 31, in reraise raise value.with_traceback(tb) File "/home/jenkins/.buildout/eggs/cp38/zope.configuration-4.4.1-py3.8.egg/zope/configuration/config.py", line 791, in execute_actions callable(*args, **kw) File "/home/jenkins/.buildout/eggs/cp38/plone.supermodel-1.6.5-py3.8.egg/plone/supermodel/model.py", line 116, in finalizeSchemas for schema in sorted(schemas): zope.configuration.config.ConfigurationExecutionError: File "/home/jenkins/.buildout/eggs/cp38/plone.supermodel-1.6.5-py3.8.egg/plone/supermodel/configure.zcml", line 9.4-12.10 <zcml:customAction handler=".model.finalizeSchemas" order="9999999" /> TypeError: '<' not supported between instances of 'Provides' and 'InterfaceClass' ``` The test failures are mostly in `plone.autoform` and in `plone.app.registry`, but strangely you do not get the error when you run only the tests for one of those packages. You really need to run the entire Plone test suite (`bin/test` in coredev, without options). So there is likely some test leakage. Python 2 does not have this problem: sorting on Python 3 is handled differently. On Python 2: ``` >>> from zope.interface.declarations import Implements, Provides >>> sorted([Implements(), Provides(object)]) [classImplements(?), directlyProvides(object)] ``` On Python 3: ``` >>> from zope.interface.declarations import Implements, Provides >>> sorted([Implements(), Provides(object)]) Traceback (most recent call last): File "<console>", line 1, in <module> TypeError: '<' not supported between instances of 'Provides' and 'Implements' ```
|
There are lots of test failures on Python 3. Those should be fixed together with plone/plone.supermodel#55. I am testing these two PRs together on Jenkins now. |
|
If Jenkins is green, then an open question is whether we dare to still put those two in a Plone 5.2 release, or if we keep this in a not-yet-existing list of package versions that you can switch to if you know what you are doing. |
That was the reason I changed this PR to draft. Thank you for carrying on. |
|
IMHO we could cut new individual distribution releases but not compile a new Plone 5.2.x release, just as @mauritsvanrees suggests: if you know what you are doing, the release is there for you to easily use it, otherwise, please move to 6.x where the fix is also applied 😄 |
Their 2.x and 1.x branches are getting some changes that *should* be fine, but feel slightly too adventurous for official inclusion in 5.2, if we ever do a new release. See plone/plone.dexterity#189 (comment)
|
Okay, I have changed the coredev 5.2 |
|
I have made releases: |
|
I propose to add a |
As also reported in plone/Products.CMFPlone#3829 (comment) it might be useful to have fix #187 also for 2.x versions for Plone 5.2 users