Skip to content

Commit

Permalink
Run docs check against Python 3.12 (#1794)
Browse files Browse the repository at this point in the history
* Run docs check against Python 3.12

* Add changelog and update more references to 3.9

* Make py 3.12 the default and print python/plone version

* Update 1794.internal

---------

Co-authored-by: David Glick <[email protected]>
  • Loading branch information
tisto and davisagli committed Jun 16, 2024
1 parent 58fe86b commit fd222a1
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .python-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.9
3.12
1 change: 1 addition & 0 deletions news/1794.internal
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update test-no-uncommitted-doc-changes to run on Python 3.12 instead of 3.9. @tisto, @davisagli
8 changes: 5 additions & 3 deletions test-no-uncommitted-doc-changes
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,14 @@ function red {
echo "$RED $1 $RESET"
}

if [ "$PLONE_VERSION" == "6.0" ] && [ "$PYTHON_VERSION" == '3.9' ]; then
echo "Running check for undocumented changes for Plone 6.0.x on Python 3.9"
if [ "$PLONE_VERSION" == "6.0" ] && [ "$PYTHON_VERSION" == '3.12' ]; then
echo "Running check for undocumented changes for Plone 6.0.x on Python 3.12"
else
# request/response dumps have known differences for different Python/Plone combinations
# => skip, we can't have the Plone 5 build fail because of those
echo "Skipping checks for undocumented changes for everything except Plone 6.0.x on Python 3.9"
echo "Skipping checks for undocumented changes for everything except Plone 6.0.x on Python 3.12"
echo "PLONE_VERSION=$PLONE_VERSION"
echo "PYTHON_VERSION=$PYTHON_VERSION"
exit 0
fi

Expand Down

0 comments on commit fd222a1

Please sign in to comment.