Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VOLTO_FRONTEND_DOMAIN as env var #139

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Conversation

sneridagh
Copy link
Member

No description provided.

@sneridagh sneridagh requested a review from davisagli January 22, 2024 13:11
@mister-roboto
Copy link

@sneridagh thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

src/plone/volto/patches.py Outdated Show resolved Hide resolved
@davisagli
Copy link
Member

@jenkins-plone-org please run jobs

@davisagli davisagli merged commit 83c8115 into main Jan 30, 2024
17 checks passed
@davisagli davisagli deleted the addfrontenddomainasenvvar branch January 30, 2024 18:00
@djay
Copy link
Member

djay commented Feb 1, 2024

@sneridagh for multitenented mode we are going to need another solution for this (and also some other settings). It would be good to know what the preferred solution is for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants