Do not set the nonfolderish_tabs registry to False #146
Conversation
|
@wesleybl thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
|
@wesleybl I would leave out the upgrade step. It's okay to change the value of the setting for new sites, but we shouldn't change it for existing sites where it might have been set intentionally. |
wesleybl
force-pushed
the
nonfolderish_tabs
branch
from
3315471 to
b5fba21
Compare
|
@jenkins-plone-org please run jobs |
@davisagli done. |
The default setting of True will be set. With this, the content types in displayed_types will appear in the menu, regardless of whether they are folderish. This mainly favored the Link type, which was not appearing in the menu because it was not folderish.
|
@sneridagh can you take a look here please? |
The default setting of
Truewill be set. With this, the content types indisplayed_typeswill appear in the menu, regardless of whether they are folderish. This mainly favored the Link type, which was not appearing in the menu because it was not folderish.fixes #145