Avoid runtime dependency on plone.app.upgrade #150
Conversation
|
@davisagli thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
There was a problem hiding this comment.
LGTM.
One additional thing that we could do here and in other packages is to conditionally load the upgrade steps:
<configure zcml:condition="installed plone.app.upgrade">
<include file="upgrades.zcml" />
<configure>
But we can discuss that separately. This PR is fine.
Fixes #142