Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail on startup when the requests library is missing. #154

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

mauritsvanrees
Copy link
Member

Conditionally load the views to migrate to Volto: only when the requests library is available. We don't want to make this a hard dependency.
If you need the migration views, you should include the requests package yourself. Fixes #152

Conditionally load the views to migrate to Volto: only when the ``requests`` library is available.
We don't want to make this a hard dependency.
If you need the migration views, you should include the ``requests`` package yourself.
Fixes #152
@mauritsvanrees mauritsvanrees requested a review from davisagli June 18, 2024 15:39
@mister-roboto
Copy link

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@mauritsvanrees
Copy link
Member Author

@jenkins-plone-org please run jobs

@davisagli davisagli merged commit 7df9f28 into main Jun 18, 2024
17 checks passed
@davisagli davisagli deleted the maurits-conditional-requests branch June 18, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'requests'
3 participants