-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Plone 5.2 and Plone 6.0 #156
Conversation
@ericof thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is anyone supposed to review this?
Can't you base this on my PR #153? I split that up into multiple commits to make it easier to review: reviewers can ignore big commits like "black", "pyupgrade", or "zpretty", and focus on the much smaller real changes.
With some git magic it would probably still be possibly to do that, without getting dozens of merge conflicts. (I don't much mind having wasted some time on my PR, that just sometimes happens when multiple people work on one project, and is not the real issue.)
Having said that: happy to see support for the older Plone versions dropped.
What is the reason for changing the i18n domain to plone.volto
?
Oh, you may want to rename the news snippet from 155.internal
to 155.breaking
. This is not quite an internal-only change. ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed only README.md
.
Can some of this content by moved into the open PR plone/documentation#1671 ?
I still need to fix dependencies and find out why tests fail in ci (but they pass locally) |
Co-authored-by: Steve Piercy <[email protected]>
I will make many PR's on top of yours. That way we can review one by one.
I changed it for 'laziness', but I see a use case for it now. Either way, I will roll it back to plone .
|
src/plone/volto/distributions/default/content/content/plone_site_root/data.json
Outdated
Show resolved
Hide resolved
The reason we are dropping support for Plone 5.2/6.0 is Plone Distributions, right? |
@tisto Right. plone.volto becomes the package which holds the default distribution. We'll create a 4.x branch where we can backport anything needed to continue supporting 5.2 and 6.0. |
Testing on jenkins with this set of PRs:
|
Just thinking: at some point we will want to remove |
default
distributionFixes #155
Before merge: