Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace head_title with Kicker #163

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Replace head_title with Kicker #163

merged 5 commits into from
Dec 11, 2024

Conversation

iRohitSingh
Copy link
Contributor

@iRohitSingh iRohitSingh commented Nov 14, 2024

Fixes #163

@mister-roboto
Copy link

@iRohitSingh thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@davisagli
Copy link
Member

@jenkins-plone-org please run jobs

@davisagli davisagli merged commit 6e26cbf into main Dec 11, 2024
10 of 11 checks passed
@davisagli davisagli deleted the head_title-kicker branch December 11, 2024 18:26
@iRohitSingh
Copy link
Contributor Author

@davisagli I think that adding kicker field to all content types broke the live update of teaser block. I looked everywhere but this is the only change which can affect the updating of kicker field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants