Fix sticky footer issue #80
Conversation
Fixes issue of sticky footer using CSS3 flexbox Fixes: #36
|
tests running here: http://jenkins.plone.org/job/pull-request-5.0/792/ |
|
Can you add a changelog entry please? |
|
Flexbox is awesome and support is really good but do we want to introduce it in Barceloneta at this time? I mean, it could have been used for the entire layout but was avoided so I'm not sure we should fix this issue like this. Any comments, @sneridagh @albertcasado ? |
|
@davilima6 Thanks for the feedback. Sticky footer can be achieved by calculating footer height and then by using general CSS method but in our case this isn't possible since users can have different footers. Other method is calculating footer's height using JavaScript and then fixing it by CSS but I thought it will be overdo since this can be achieved by mixing old and new flexbox for better browser support. |
|
plonetheme.barceloneta is not using Flexbox at all (mainly because it's based on vainilla BS3). Introduce it at this level (thorough the whole page structure) is kind of risky and will require more testing for all viewports. Then we have the cross browser support. I remember deciding for Plone 5 to support from IE9+ onwards. This change will break this, making it IE10+, isn't it?. It's true that MS have officially deprecated IE10 and backwards, however I would wait for a minor version update (eg. Plone 5.1) to make this change effective. @vangheem @albertcasado @davilima6 what do you think? |
| @@ -2270,6 +2274,7 @@ fieldset[disabled] .link-parent.active { | |||
| color: #777777; | |||
| } | |||
| .pagination { | |||
| display: inline-block; | |||
There was a problem hiding this comment.
Do we want to switch this to inline-block?
There was a problem hiding this comment.
It's compiling from pagination.plone.less, line 4. I don't know why it wasn't in barceloneta-compiled.css already.
inline style tags are now included
Center the leadimage on the modal windows
Signed-off-by: Rene Jochum <[email protected]>
Add barceloneta-mixin-font to the registerless profile.
Its required by barceloneta-fonts.
Add barceloneta-mixin-font to plone.export.less.
Calculates height of footer on page load and on resize and set bootom padding of body according to it to keep footer at bottom. Fixes: #36
Removes changes done for flexbox fix. Now we calculate footer height using jquery and sets bottom padding of body to keep the footer at bottom. Fixes: #36
|
There was no activity on this for a while. I close this request for now. If you plan to work further on this please reopen and go on. |
|
Yeah sure |
Fixes issue of sticky footer using CSS3 flexbox
Fixes: #36