Remove "Generate tabs for items other than folders" field from navigation control panel #6278
Conversation
✅ Deploy Preview for plone-components canceled.
|
wesleybl
force-pushed
the
nonfolderish_tabs
branch
from
f78d4a4 to
ff11b98
Compare
navigation control panel The help for this field says: "By default, any content item in the root of the portal will appear as a tab. If you turn this option off, only folders will be shown. This only has an effect if 'automatically generate tabs' is enabled." This doesn't make sense in Volto. Volto doesn't display item as tab
* main: (97 commits) Release 18.0.0-alpha.43 Release @plone/slate 18.0.0-alpha.18 Release @plone/client 1.0.0-alpha.17 Added a notice in the upgrade guide for CookiePlone as the recommended way for generating projects and add-on boilerplate (#6286) Fix typo in Changelog for #6285 (#6287) Update to Volto 6.0.13 (#6285) Fix order component (#6284) Remove dangling `.only` in Cypress test (#6282) Empty GridBlocks will not be rendered in 'View' (#6280) Refactor Content upload modal (#5047) Passes the `user` to the `restricted` function of the block settings (#6271) Refactored SelectMetadataField.jsx to functional component (#5570) Remove "Generate tabs for items other than folders" field from navigation control panel (#6278) Refactor DatetimeWidget (#6213) Added make i18n to volto (#6274) Place the actions-storybook in correct folder (#6275) Refactor ReferenceWidget (#5093) Fix error in SortOn component when there is no sort selected. (#6273) When user changes location, set the userSession.token value based on cookie (#6079) Trivial MyST syntax enhancement ...
|
I'm checking the release notes for Volto 18a43 and found this issue. The change still might be good, but the motivation in the issue itself is strange. With 'tabs' the visual representation of the main navigation section is meant. This used to be a tab, but with Plone 5.2 we already got nested navigation. These settings can still make sense both in Volto and Classic UI. just replace 'tab' with 'main section'. You could disable the automatic population of main section items based on the contents of the root folder. (if you disable it, use actions to manually fill the main section). And in case you do automatic population, you could still choose to ony show Folders, or in Volto's default case Folderish pages, or allow any item of a content type to be in the main section. So why was this option removed from the Volto control panel? |
@fredvd what exactly are you calling the "main section" in Volto? Is it a navigation menu item? After your question, I did a test, and I saw that when this option is selected, the navigation menu also displays non-Folderish items, such as Link. So, it might make sense to have this option in Volto. But the term "tab" is really strange. |
|
The term tabs is strange indeed. but is just a help/field label text that hasn't been updated for the Volto frontend and after Plone 5.2 dropdownmenu's were added. with main section is the main 'horizontal' navigation section we have in a plain Plone site. |
|
I think it would be better:
|
|
That still doesn't make much sense for Volto because Volto doesn't have folders, and there's a separate setting for which content types to show in navigation. |
The displayed_types you refer to not only work for the main section navigation, but also for the contextnavigation component and I suspect the site-index. It's a different setting with different purpose. |
If the content is not Folderish, such as Link, and this option is not selected, the item will not appear in the navigation menu, even if the Link type is selected to be displayed in the navigation menu. |
It could be: Generate navigation items for contents other than Folderish |
@fredvd in Plone Classic, is it possible to manually add items to the navigation menu? How to do this? Will this work on Volto? |
The help for this field says:
By default, any content item in the root of the portal will appear as a tab. If you turn this option off, only folders will be shown. This only has an effect if 'automatically generate tabs' is enabled.This doesn't make sense in Volto. Volto doesn't display item as tab.